add docs_rs_crates_io subcrate for interaction / shared types#3357
add docs_rs_crates_io subcrate for interaction / shared types#3357syphar wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
S-waiting-on-review
| /// is the release yanked? | ||
| pub yanked: bool, |
There was a problem hiding this comment.
Is this required? I think this could be inferred in all cases except deletion, in which case I'm not sure it matters anyway for you.
| pub yanked: bool, | ||
| /// The semantic version of the crate. | ||
| #[serde(rename = "vers")] | ||
| pub version: semver::Version, |
There was a problem hiding this comment.
At the point we'd be generating these messages on crates.io, we've already validated the version number and only have it as a String, since that's what we use in the database models. Would you be OK changing this to String?
There was a problem hiding this comment.
If that's better for you, we can do it.
( docs.rs works with semver::Version everywhere, and converts it always when fetching from the DB).
|
Btw, you created this crate but it's not used anywhere in our codebase for now. Shouldn't we plug it into our codebase in this PR directly? |
usage is WIP in #3349. Idea is:
|
|
( waiting for approval from @LawnGnome too before merging / releasing) |
3 participants
first use-case is the SQS link for index changes that will replace our git index usage